Avoid creating new references on WithDeferredSetup for every span
#3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
changed the title
WithDeferredSetup callWithDeferredSetup for every span
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 170 170
Lines 12474 12474
=====================================
Hits 10190 10190
Misses 2069 2069
Partials 215 215
|
alanprot
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
approved these changes
Mar 7, 2023
hanyuancheung
approved these changes
Mar 7, 2023
MadVikingGod
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are creating new
doDeferredContextSetupTypereferences for every span on this function making the GC busier for no reason (specially on a very high tps service).This change is just using a global reference instead of creating one for every span.