-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource: Add testable example #4887
Merged
pellared
merged 10 commits into
open-telemetry:main
from
pellared:resource-testable-example
Feb 8, 2024
Merged
resource: Add testable example #4887
pellared
merged 10 commits into
open-telemetry:main
from
pellared:resource-testable-example
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
added
documentation
Provides helpful information
area:resources
Part of OpenTelemetry resources
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Feb 6, 2024
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
February 6, 2024 12:14
dashpole
reviewed
Feb 6, 2024
MrAlias
reviewed
Feb 6, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…ed/opentelemetry-go into resource-testable-example
dashpole
approved these changes
Feb 7, 2024
dmathieu
approved these changes
Feb 7, 2024
MrAlias
reviewed
Feb 7, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Feb 7, 2024
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:resources
Part of OpenTelemetry resources
documentation
Provides helpful information
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4879
I did my best to add some testable example to the
resource
that will demonstrate how one can use theNew
function and the fact that the error result may be ignored.Based on https://opentelemetry.io/docs/languages/go/resources/
You can also see open-telemetry/opentelemetry.io#3949