Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: Add testable example #4887

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 6, 2024

Fixes #4879

I did my best to add some testable example to the resource that will demonstrate how one can use the New function and the fact that the error result may be ignored.

Based on https://opentelemetry.io/docs/languages/go/resources/

You can also see open-telemetry/opentelemetry.io#3949

@pellared pellared added documentation Provides helpful information area:resources Part of OpenTelemetry resources Skip Changelog PRs that do not require a CHANGELOG.md entry labels Feb 6, 2024
@pellared pellared mentioned this pull request Feb 6, 2024
@pellared
Copy link
Member Author

pellared commented Feb 7, 2024

@dashpole @MrAlias Ready for review.

sdk/resource/example_test.go Outdated Show resolved Hide resolved
sdk/resource/example_test.go Outdated Show resolved Hide resolved
sdk/resource/example_test.go Outdated Show resolved Hide resolved
sdk/resource/example_test.go Outdated Show resolved Hide resolved
sdk/resource/example_test.go Outdated Show resolved Hide resolved
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared requested a review from MrAlias February 7, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:resources Part of OpenTelemetry resources documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource: Add testable example that ignores schema URL conflict error
4 participants