Make the JDBC driver config work with the OTel starter #9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
commented
Oct 8, 2023
...on/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Outdated
Show resolved
Hide resolved
jeanbisutti
commented
Oct 8, 2023
|
|
||
| tasks.test { | ||
| useJUnitPlatform() | ||
| setForkEvery(1) |
kenfinnigan
reviewed
Oct 10, 2023
trask
reviewed
Oct 12, 2023
...tion/spring/autoconfigure/instrumentation/jdbc/OpenTelemetryJdbcDriverAutoConfiguration.java
Show resolved
Hide resolved
trask
reviewed
Oct 12, 2023
smoke-tests-otel-starter/src/main/resources/application-jdbc-driver-config.properties
Show resolved
Hide resolved
|
@open-telemetry/java-instrumentation-maintainers and @open-telemetry/java-instrumentation-approvers, would you have other comments? |
|
I have tried to do an implementation in the same way as for logging with an |
trask
reviewed
Oct 19, 2023
...on/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Show resolved
Hide resolved
...on/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Outdated
Show resolved
Hide resolved
brunobat
suggested changes
Oct 20, 2023
...on/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Oct 20, 2023
...tion/spring/autoconfigure/instrumentation/jdbc/OpenTelemetryJdbcDriverAutoConfiguration.java
Show resolved
Hide resolved
Comment on lines
+23
to
+26
| @Bean | ||
| OpenTelemetryInjector injectOtelIntoJdbcDriver() { | ||
| return openTelemetry -> OpenTelemetryDriver.install(openTelemetry); | ||
| } |
There was a problem hiding this comment.
can the approach used for logging work here?
There was a problem hiding this comment.
It's the first thing I have tried. It does not work.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
brunobat
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
I've tested it with Quarkus with no side effects. Thanks @jeanbisutti !
Thank you @brunobat for having tested that these changes won't break things on Quarkus! |
mateuszrzeszutek
approved these changes
Oct 23, 2023
| @@ -48,6 +52,8 @@ public final class OpenTelemetryDriver implements Driver { | |||
| // visible for testing | |||
| static final OpenTelemetryDriver INSTANCE = new OpenTelemetryDriver(); | |||
|
|
|||
| private OpenTelemetry openTelemetry = OpenTelemetry.noop(); | |||
There was a problem hiding this comment.
Shouldn't it be volatile?
trask
approved these changes
Oct 23, 2023
Abhishekkr3003
pushed a commit
to Abhishekkr3003/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 7, 2023
…y#9625) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.