Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix and update getting-started #1553

Merged
merged 4 commits into from
Sep 30, 2020
Merged

docs: fix and update getting-started #1553

merged 4 commits into from
Sep 30, 2020

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Sep 25, 2020

As mentioned in #1509 (comment) there are a few other issues in the getting started guide I fixed: Typos, outdated images for zipkin, version bumps and bringing the TypeScript example on par with the Javascript ones.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1553 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         158      158           
  Lines        4882     4882           
  Branches      988      988           
=======================================
  Hits         4543     4543           
  Misses        339      339           

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 12 to 13
.then(result => {
res.send(result.data);
Copy link
Member

@naseemkullah naseemkullah Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: axios docs refers to this as response rather than result

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed that.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a bit difficult to see real changes, as it looks like you have created a new files, did you delete old files without changing the name or its a git which messes the history?.
You mentioned that you updated screenshots, but I only see 2 that were deleted, what's happened with them ?

@svrnm
Copy link
Member Author

svrnm commented Sep 30, 2020

@obecny thanks for calling this out.

Regarding the images the Files changed view here on github tells me that the images have been modified with a decreased file size, not deleted.

the deleted file (tracing.ts) is now in ts-example/traced-example. I didn't move that file but created a new one, I guess that's why it is not marked as "moved".

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you right images weren't deleted

@obecny
Copy link
Member

obecny commented Sep 30, 2020

@svrnm pls fix the conflicts

@svrnm
Copy link
Member Author

svrnm commented Sep 30, 2020

@obecny TBH I have no idea how I should resolve this conflict. Any guidance is appreciated.

@svrnm
Copy link
Member Author

svrnm commented Sep 30, 2020

@obecny Never mind I figured out, asking google the right questions helps ;-)

@obecny obecny added the enhancement New feature or request label Sep 30, 2020
@obecny obecny merged commit 11947bf into open-telemetry:master Sep 30, 2020
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* docs: document merge reqiurements

* docs: remove redundant wording

* docs: remove redundant wording

* docs: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants