-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use serializers in browser exporters #4581
feat!: use serializers in browser exporters #4581
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4581 +/- ##
==========================================
+ Coverage 90.77% 92.86% +2.08%
==========================================
Files 90 330 +240
Lines 1930 9518 +7588
Branches 417 2041 +1624
==========================================
+ Hits 1752 8839 +7087
- Misses 178 679 +501
|
826e28a
to
5651eb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks great!
* feat!: use serializer in browser exporters * feat!: remove unused convert * fixup! feat!: use serializer in browser exporters * chore: update changleog
Description
Follow-up to #4542, applies the
ISerializer
s from that PR to the browser exporters.@opentelemetry/otlp-proto-exporter-base
as the base classes are not needed anymore (serialization is handled in the same way as for JSON)convert()
from all exporters as it's now handled by theISerializers
RequestType
) from the type parameter list of the exporter baseconvert()
this is now fully internal and can be removed along with sub-types in a follow-up PRBreaking:
OTLPExporterBase
: removedRequestType
from type parametersOTLPExporterBase
: removedOTLPExporterBase#convert()
OTLPExporterBrowserBase
: constructor now requires anISerializer
andcontentType
@opentelemetry/otlp-proto-exporter-base
was removed as serialization is now part of@opentelemetry/otlp-transformer
, base classes from@opentelemetry/otlp-exporter-base
can now be used instead of the protobuf-specific ones.Enables #4116
Follows: #4542