Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-http): adapt to current @types/node #548

Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 18, 2019

Which problem is this PR solving?

fixes #541

Short description of the changes

Adapt http/https plugin to @types/node 12.12.9

Refs: #545

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #548 into master will decrease coverage by 2.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   92.98%   90.13%   -2.85%     
==========================================
  Files         147      142       -5     
  Lines        7694     7057     -637     
  Branches      654      641      -13     
==========================================
- Hits         7154     6361     -793     
- Misses        540      696     +156
Impacted Files Coverage Δ
...opentelemetry-plugin-http/test/utils/assertSpan.ts 100% <ø> (ø) ⬆️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 66.66% <0%> (-33.34%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 37 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
does it mean that this PR, can be closed then in favour of this ?

@Flarna
Copy link
Member Author

Flarna commented Nov 18, 2019

yes, one is enough.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also upgrade @types/node to ^12.12.8?

@Flarna
Copy link
Member Author

Flarna commented Nov 18, 2019

I can adapt the package.json files. Only http/https or all 24 packages?

@dyladan
Copy link
Member

dyladan commented Nov 18, 2019

I can adapt the package.json files. Only http/https or all 24 packages?

I see no reason not to do all 24

@dyladan
Copy link
Member

dyladan commented Nov 18, 2019

@Flarna are you going to update the other package.jsons?

@Flarna
Copy link
Member Author

Flarna commented Nov 18, 2019

@dyladan Nope, I updated only http/https and only @types/node.

@mayurkale22
Copy link
Member

@dyladan Nope, I updated only http/https and only @types/node.

Ok, I can handle that in next PR. Thanks @Flarna for the work.

@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Nov 18, 2019
@mayurkale22 mayurkale22 merged commit b57951c into open-telemetry:master Nov 19, 2019
@Flarna Flarna deleted the http-plugin-types branch November 19, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http/https plugins are not compatible to @types/node 12.12.8
6 participants