Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decode jaeger header #735

Merged
merged 7 commits into from
Jan 29, 2020
Merged

Conversation

DotSpy
Copy link
Member

@DotSpy DotSpy commented Jan 27, 2020

Which problem is this PR solving?

Short description of the changes

  • try to decode jaeger header when extracting

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan added the enhancement New feature or request label Jan 28, 2020
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #735 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   92.62%   92.64%   +0.02%     
==========================================
  Files         227      227              
  Lines       10330    10305      -25     
  Branches      937      931       -6     
==========================================
- Hits         9568     9547      -21     
+ Misses        762      758       -4
Impacted Files Coverage Δ
...ckages/opentelemetry-plugin-ioredis/src/ioredis.ts 100% <100%> (ø) ⬆️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-http/src/version.ts 100% <0%> (ø) ⬆️
...in-postgres/opentelemetry-plugin-pg/src/version.ts 100% <0%> (ø) ⬆️
... and 14 more

@dyladan dyladan merged commit 4a83613 into open-telemetry:master Jan 29, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* feat: decode jaeger header

* fix: gts fix

* fix: use const instead of variables

* fix: use const for headers

Co-authored-by: Uladzislau Kiva <vladislav.kiva@moneyman.ru>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger incoming headers format should be able to accept url encoded value
6 participants