Skip to content

Conversation

rads-1996
Copy link
Contributor

@rads-1996 rads-1996 commented Sep 29, 2025

Fixed an issue #2352 where http_server_request_duration metrics was being recorded for excluded urls.

Description

Fixes #2352

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • A flask application was set up using the reproduction steps outlined in the linked issue, and the before-and-after changes have been captured and attached to the PR.
  • Modified existing unit tests to conform to new functionality

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

… metrics was being recorded for excluded urls.
@rads-1996 rads-1996 requested a review from a team as a code owner September 29, 2025 21:26
@rads-1996
Copy link
Contributor Author

In the current scenario, when requests are made to the excluded /health endpoint, each hit is recorded as a failed request. For this instance, 7 requests were made to the /health endpoint -

image

After the change, server request duration metrics are recorded only for non-excluded URLs. In this case, 3 requests were made to the /health endpoint -

Screenshot 2025-09-29 143914

@rads-1996 rads-1996 marked this pull request as draft September 29, 2025 21:59
@rads-1996 rads-1996 marked this pull request as ready for review September 29, 2025 23:35
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Azure Exclude URL Errors
1 participant