Skip to content

Conversation

lizthegrey
Copy link
Member

No description provided.

@lizthegrey lizthegrey requested a review from a team March 12, 2020 14:03
@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #481 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files          43       43           
  Lines        2213     2213           
  Branches      248      248           
=======================================
  Hits         1969     1969           
  Misses        173      173           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8521e...000e298. Read the comment docs.

trace_integration(tracer_provider(), mysql.connector, "connect", "mysql")
trace_integration(tracer_provider(), mysql.connector, "connect", "mysql", "sql")
# Ex: pyodbc
trace_integration(tracer_provider(), pyodbc, "Connection", "odbc", "sql")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import for pyodbc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@c24t c24t merged commit 52332ce into master Mar 12, 2020
@codeboten codeboten deleted the lizf.pyodbc branch December 12, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants