-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix!: remove enable_recognize_route and span_naming options
`recognize_route` can end up mutating the request object in the event it processes a potential match that is not anchored. That is, shall we say, not ideal. (And causes production applications to break). I was initially going to just default the options to `off` (essentially), but why leave potentially dangerous code lying about? Also, it ended up being easier to just yank stuff out rather than fix the test cases to handle the inverse of what the expected, etc. So, this commit just removes it all. Step backwards in convenience, sure. Big step forward in safety? Definitely. For context: https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/123/files#r1035711863
- Loading branch information
Showing
4 changed files
with
6 additions
and
146 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters