New refactor nomencleture change #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding fix for upper case not supported check for property names * Fixing lint issues * resolving list issues * Fix PR comments * downgrade ubuntu version to support setup.py * fix lint issue * changes as per PR comment * submit PR comment fixes * fix lint issues
* moving proto generation out of sdk generation * resolving lint issues * downgrade ubuntu version to support setup.py * adding validation of generated yaml and proto in CI * fix typo * correcting job nomencleture * resolving review comments --------- Co-authored-by: vhowdhur <vibaswan.roychowdhury@keysight.com>
* support env where go and protoc are already visible in PATH * fix for python 2 * always upload archives * fixed go package option generation * fixed linting error * updated go linter * drop support for go 1.17 * re-introduce go 1.17 * skip go linter for go 1.17 and go1.18 * install older go linter for older go version
…397) * initial commit * fixed unit tests
* generate version API spec * added code generation for Go * fixed error response generation * added support for version check in python SDK * added mock server tests for version check * fixed HTTP tests
* initial change * code changes to allow choice with no properties * complete python support for choices with no properties * complete test cases for go sdk * commit pending merge change * rectifies an issue related to version check * resolving review comments and adding tests
* openapiart/generator.py * Fix lint issue * set API args should be set to None. * refactored code as per PR comments. * adding serialize to end of test added 2 negative tests- 1. required property is not set 2. an optional property is set with a value of different type
|
models successful run snappi successful run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391