Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

fix sample page button #291

Merged
merged 1 commit into from
Oct 18, 2019
Merged

fix sample page button #291

merged 1 commit into from
Oct 18, 2019

Conversation

wayunge
Copy link
Contributor

@wayunge wayunge commented Oct 17, 2019

No description provided.

@wayunge wayunge requested a review from jianjunz as a code owner October 17, 2019 08:42
@jianjunz
Copy link
Collaborator

jianjunz commented Oct 18, 2019 •
edited
Loading

This fix assumes the resolution list sent from server is in descending order. It would be better to sort resolutions in JavaScript to avoid server side behavior changes.

jianjunz
jianjunz approved these changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@jianjunz jianjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But at least, it works for now.

@jianjunz jianjunz merged commit 95725bd into open-webrtc-toolkit:master Oct 18, 2019
@jianjunz
Copy link
Collaborator

Fix #231.

@wayunge wayunge deleted the buttonfix branch October 18, 2019 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jianjunz jianjunz jianjunz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wayunge @jianjunz