refactored trim() out of expand #67

gfudenberg · 2021-03-14T21:20:45Z

readme links update
docstrings update (relates to docstrings: assorted collection of typos and misleading statements #63)
expand no longer in place (should close expand modifies the df in place #66)
refactored trim() out of expand, this didn't seem to hurt performance very much.

bioframe/ops.py

golobor · 2021-03-24T20:47:29Z

bioframe/ops.py

+    df,
+    min_sep,
+    max_sep,
+    min_interjacent=None,


double check if Nezar hasn't already changed this name in one of @agalitsyna 's PRs

tests/test_ops.py

gfudenberg · 2021-04-01T17:50:51Z

need to determine upper limit handling for trim, either clip both sides at both limits, or clip intervals such that lower<upper:

golobor

Das ist gut!!

gfudenberg and others added 3 commits March 12, 2021 12:42

fix-readme-links

d44bf71

ops-docstrings-and-extend-inplace

24fd1ad

refactor-expand-with-trim

330e9de

gfudenberg requested a review from golobor March 14, 2021 21:20

sergpolly mentioned this pull request Mar 16, 2021

docstrings: assorted collection of typos and misleading statements #63

Closed

Geoff Fudenberg added 3 commits March 16, 2021 11:33

update-expand-for-negative-pad

1c55142

multiplicative-expand-and-test

1022b03

fill-dfs-with-none-instead-of-pd.NA

22c6521

golobor reviewed Mar 25, 2021

View reviewed changes

trim-out-of-expand

6c8dea5

Geoff Fudenberg added 3 commits April 1, 2021 10:58

black-update

c961d74

trim-none-instead-of-zero

0e47398

limits=None

935f0ea

golobor reviewed Apr 13, 2021

View reviewed changes

golobor merged commit a4fc688 into open2c:master Apr 13, 2021

Provide feedback