Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows and macos platforms to CI #383

Merged
merged 14 commits into from
Feb 2, 2024

Conversation

nvictus
Copy link
Member

@nvictus nvictus commented Jan 30, 2024

  • Add Windows (and MacOS) runner to CI
  • Make Windows-incompatible optional dependencies (pypairix, pysam) platform-dependent
  • Handle Windows paths with drive letters and colons correctly
  • Manually clean up NamedTemporaryFile on Windows to allow re-opening (see Python docs for more info).
  • Force Unix-style line endings in CLI commands that output delimited text.

@nvictus nvictus force-pushed the ci-windows-macos-tests branch 2 times, most recently from ae2e3dd to 11ede46 Compare February 1, 2024 21:54
Copy link
Contributor

@thomas-reimonn thomas-reimonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I see it running on windows, Mac and ubuntu.

@nvictus nvictus merged commit fab84a4 into open2c:master Feb 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants