Add regions to compartments CLI and other fixes for regions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba32874.
Phlya
changed the title
sergpolly
approved these changes
May 14, 2021
There was a problem hiding this comment.
- Modified reading regions in call-compartments to be similar to other CLI tools
- call-dots has --out-prefix now, instead of output-calls - output files are explained better, and the option is required
- some black here and there
- test_call_dots checks is the output files exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply added a
regionsargument tocall-compartmentsand pass it into the API when asking for cis contacts (regions for trans are not implemented in the API)