Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix bugs in stats #200

Merged
merged 1 commit into from
Mar 9, 2024
Merged

quick fix bugs in stats #200

merged 1 commit into from
Mar 9, 2024

Conversation

sergpolly
Copy link
Member

addressing stats issue #199

the issue stems mostly from the fact that dist_freq became a dictionary by distance-bin instead of being an ndarray (before v1.0) - then there 2 different interpretation of that dict happen:

  1. keys being dist_bin themselves in __init__, add_pair, add_pairs_fromdataframe_chunk ...
  2. keys being bin_id of a given distance (i.e. bin_id = np.searchsorted(self._dist_bins, some_distance)) in places like from_file and __gfetitem__

This is minimal fix PR - where we switch to dist_freq - as a dict with dist-keys - i.e. changing from_file and __getitem__

Then there is just a simple bug/typo in flatten, where dist is incorrectly defined for the very last open-ended distance interval - it is fixed here as well

@sergpolly sergpolly mentioned this pull request Jan 5, 2024
@sergpolly sergpolly added the bug label Jan 5, 2024
@golobor golobor merged commit f6574dd into master Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants