Fix 1088 Message displayed when user is successfully signed in #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShivangiSingh17 can you help why there is travis ci check error? |
|
|
|
yes,i got that.thanks! @aggarwalpulkit596 |
Fix 1088 Message displayed when user is successfully signed in
|
@theabhishekavi Create a PR on this Library REPO and make changes there accordingly. |
miPlodder
reviewed
Mar 14, 2019
| @@ -46,6 +47,7 @@ public int getLogo() { | |||
|
|
|||
| @Override | |||
| public void startNextActivity() { | |||
| Toast.makeText(this, "Logged in succesfully", Toast.LENGTH_SHORT).show(); | |||
There was a problem hiding this comment.
Don't use hard-coded strings. Write them in strings.xml file and use them. (Do this in the repo that I have commented on the PR)
|
Shifted to Library Repo: openMF/mifos-passcode#24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088
Screenshots
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.