Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty <xref/> does not trigger a warning #9

Closed
taroth21 opened this issue Oct 28, 2016 · 1 comment
Closed

Empty <xref/> does not trigger a warning #9

taroth21 opened this issue Oct 28, 2016 · 1 comment
Assignees
@tomschr
Labels
bug 🐛 Something isn't working as expected geekodoc Version independent general GeekoDoc issues
Milestone
0.9.6

Comments

@taroth21
Copy link
Contributor

taroth21 commented Oct 28, 2016 •
edited
Loading

I inserted an empty <xref/> element in the text (which I forgot to fill with a linkend attribute). When validating the document, GeekoDoc did not complain about the empty <xref/> element . I only spotted it by accident. IMHO, GeekoDoc should warn about empty <xref/> elements.
@tomschr tomschr self-assigned this Nov 22, 2016
@tomschr tomschr added bug 🐛 Something isn't working as expected geekodoc Version independent general GeekoDoc issues labels Nov 22, 2016
@tomschr tomschr added this to the 0.9.6 milestone Nov 22, 2016
@tomschr
Copy link
Contributor

tomschr commented Nov 22, 2016

Fixed in commit 0170910

@tomschr tomschr closed this as completed Nov 22, 2016
tomschr added a commit that referenced this issue Nov 24, 2016
@tomschr
Merge tag 'v0.9.6' into develop
741bafe 
Release 0.9.6

* GeekoDoc
  * Remove title in step (#4)
  * Empty <xref/> does not trigger a warning (#9)
  * Allow common attributes in link (#10)
  * Disallow xreflabel (#11)
  * Restrict <results> element (#14)

* Novdoc
  * Missing novdocx-core.rnc (#5)
  * Allow <mediaobject> only in <figure> and <informalfigure> (#7)
  * Fix content model for step to allow para, substeps, para (#12)
  * Allow phrase inside productnumber (#13)

* Both
 * Update Novdoc/GeekoDoc to disallow screen in entry (#2)
@ghost ghost mentioned this issue Nov 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomschr tomschr

Labels
bug 🐛 Something isn't working as expected geekodoc Version independent general GeekoDoc issues
Projects
None yet
Milestone
0.9.6
Development

No branches or pull requests
2 participants
@tomschr @taroth21