Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Codebase #175

Merged
merged 10 commits into from
May 22, 2023
Merged

Modernize Codebase #175

merged 10 commits into from
May 22, 2023

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented May 12, 2023 •
edited
Loading

  • Migrate from anachronistic pbr to hatch
  • Remove deprecated usage of pkg_resources and distutils
  • Replace last usage of XMLRPC API

@bnavigator bnavigator changed the title Migrate pep517 Migrate from setup.py to PEP517 pyproject.toml with hatch May 12, 2023
@bnavigator bnavigator changed the title Migrate from setup.py to PEP517 pyproject.toml with hatch Modernize Codebase May 13, 2023
@bnavigator bnavigator force-pushed the migrate-pep517 branch 2 times, most recently from 6e08522 to 4ed25f0 Compare May 13, 2023 13:25
@bnavigator bnavigator mentioned this pull request May 15, 2023
Closed
@bnavigator
Copy link
Contributor Author

Should probably add @thesp0nge to a project.maintainers table in pyproject.toml as well

@thesp0nge
Copy link
Member

yes, thanks.

@bnavigator
Copy link
Contributor Author

Rebased onto current master

danigm
danigm approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. It's really nice to have this code updated. I've not done deep testing of this, but code wise looks good to me.

@mcepl
Copy link
Contributor

mcepl commented May 22, 2023

Thank you, @bnavigator !

@mcepl mcepl merged commit a4ab822 into openSUSE:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danigm danigm danigm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnavigator @thesp0nge @mcepl @danigm