Make finishReason nullable #51 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the OpenAI API means that finish_reason is sometimes returned as NULL and causes an exception. This change allows finishReason to be nullable.
|
Thanks for this @careybaird, was just about to report it as an issue and then saw your PR, I'd say I get this 60-70% of the time, hopefully this will be merged soon 🥳 |
|
tagging @nunomaduro as I believe this issue is urgent, it affects everyone |
|
Same issue here, really urgent for us as well, since we cannot continue developing our software without this. Thank you for the PR @careybaird |
|
Came here to make the same PR - thanks for pushing the change - agreed this should be a priority merge, affecting a lot of requests. |
|
@nunomaduro can you tag a new release with this fix? Thanks |
|
If you want a workaround to use this now, see this: #50 (comment) |
|
Fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the OpenAI API means that finish_reason is sometimes returned as NULL and causes an exception.
This change allows finishReason to be nullable.