gym.spaces.Tuple inherits from collections.abc.Sequence #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the PR I did a few months back (#2446), the tuple wrapper of gym should inherits from the abstract interface of Python. It is important for type check via `isinstance` and enable using such objects transparently with libraries such as [dmtree](https://github.com/deepmind/tree). It will bring a way helper methods along the way but it cannot be avoided to interoperability: : `__iter__`, `__reversed__`, `index`, and `count` Personally I don't think it is an issue since it is new features and it is not conflicting. As the previous PR, this patch is NOT removing any existing feature and should not break backward compatibility.
|
Will the additional methods work properly? ( |
|
If the abstract methods are implemented are working, which is the case here, them yes it will without any doubt 👍 Like |
|
We still need to add tests though |
|
Ok now it should be fine. All tests pass. |
|
This looks alright now, it's pretty minor and inoffensive unless I'm missing something very weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the PR I did a few months back (#2446), the tuple wrapper of gym should inherits from the abstract interface of Python. It is important for type check via
isinstanceand enable using such objects transparently with libraries such as dmtree.It will bring a way helper methods along the way but it cannot be avoided to interoperability: :
__iter__,__reversed__,index, andcountPersonally I don't think it is an issue since it is new features and it is not conflicting.
As the previous PR, this patch is NOT removing any existing feature and should not break backward compatibility.