Fixed warnings produced by test_record_video.py and test_video_recorder.py #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.py by using the self._frames_per_sec value as default value if video.frames_per_second is missing
… video.output_frames_per_seconds are the updated frames_per_sec and output_frames_per_sec values
This was referenced Mar 17, 2022
|
Thank you for this PR. @jkterry1 this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2654, test_record_video.py and test_video_recorder.py were throwing new warnings
This was caused by the new render_fps value being different from the default backward compatible value.
Updated the default backward compatible values to be the up to date parameters