Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment agnostic {mode}_list render mode #3060

Merged
merged 2 commits into from
Sep 4, 2022

Conversation

younik
Copy link
Contributor

@younik younik commented Sep 4, 2022

After #3040, it makes sense to handle frame collection modes with a simple Wrapper (similar to HumanRendering).
This allows environments that can work with single rendering to support frame collection modes for free, while other environments can still define their own behavior by simply adding rgb_array_list (or whatever) to metadata.

This PR:

  • Removes Renderer util in favor of the new Wrapper RenderCollection
  • If an environment supports rgb_array (or another mode), it should not do anything to support rgb_array_list (or mode_list), because during making the environment will be wrapped with RenderCollection that will handle it
  • If an environment needs custom code for rgb_array_list, it can add rgb_array_list in metadata and the RenderCollection wrapper will not be applied. In this case, the environment should handle internally the mode rgb_array_list.

@younik younik changed the title model agnostic {mode}_list render mode environment agnostic {mode}_list render mode Sep 4, 2022
@pseudo-rnd-thoughts
Copy link
Contributor

LGTM

@jkterry1 jkterry1 merged commit 0608263 into openai:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants