Switch to Latest atari-py and Bump Atari Environments to v4 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tlbtlbtlb @joschu is this the right approach for updating environments, or would you rather keep v3 for now and deprecate it? Note that as of openai/atari-py@acea408 atari-py is at 0.0.22-dev and not yet 0.0.22 so that needs to be updated and distributed first. @nottombrown is there further testing you had in mind before dropping the Who should I ask about updating the package? |
|
I didn't have any additional tests in mind
On Tue, May 9, 2017 at 11:12 AM Evan Shelhamer ***@***.***> wrote:
@tlbtlbtlb <https://github.com/tlbtlbtlb> @joschu
<https://github.com/joschu> is this the right approach for updating
environments, or would you rather keep v3 for now and deprecate it? Note
that as of ***@***.***
<openai/atari-py@acea408>
atari-py is at 0.0.22-dev and not yet 0.0.22 so that needs to be updated
and distributed first. @nottombrown <https://github.com/nottombrown> is
there further testing you had in mind before dropping the dev suffix?
Who should I ask about updating the package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#584 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASt3wehKdCt-jc5cIroE32-358c1Dhrks5r4KybgaJpZM4NVrfQ>
.
--
I enjoy constructive feedback. If you have anything you'd like to tell
me anonymously, you can post it here:
http://www.admonymous.com/nottombrown
|
shelhamer
force-pushed
the
atari-v4
branch
2 times, most recently
from
0f3f8e6
to
da61238
Compare
shelhamer
added a commit
that referenced
this pull request
May 14, 2017
gym 0.9.1 upgrades the Atari environments to v4 by: - upgrading atari-py to the latest ALE, including ROM fixes openai/atari-py#15 - upgrading gym to the latest atari-py and declaring Atari v4 #584 - exposing snapshot/restore of Atari environments through gym #575 Switching to v4 is encouraged for correctness, although the environment differences are minor. For exact comparison with existing Atari v3 results, make use of earlier gym and atari-py versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest atari-py includes ROM fixes and improvements for saving/loading environment states. Given the slight alterations to certain ROMs and a change in the seeding and pseudorandomness openai/atari-py#15 (comment) runs before and after these changes are not strictly comparable. For this reason we should bump Atari environment versions to v4 when the new atari-py is adopted.
For more detail see openai/atari-py#15 which updated the emulator to the latest ALE, included several ROM fixes, and exposed the full saving and loading of environment states.