Cleanup io and add hop_lengths to vq #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prafullasd
reviewed
Apr 30, 2020
jukebox/utils/io.py
Outdated
| @@ -101,7 +80,7 @@ def load(file, loader): | |||
|
|
|||
| files = librosa.util.find_files('/root/data/', ['mp3', 'm4a', 'opus']) | |||
| print(files[:10]) | |||
| loader = load_pyav | |||
| loader = load_sound | |||
There was a problem hiding this comment.
should this be load_audio?
prafullasd
reviewed
Apr 30, 2020
| if multipliers is None: | ||
| self.multipliers = [1] * levels | ||
| else: | ||
| assert len(multipliers) == levels, "Invalid number of multipliers" | ||
| self.multipliers = multipliers | ||
| self.z_shapes = z_shapes = [(x_shape[0] // np.prod(pow_w[:i]),) for i in range(1,levels+1)] | ||
| self.z_shapes = z_shapes = [(x_shape[0] // self.hop_lengths[level],) for level in range(levels)] |
There was a problem hiding this comment.
this seems fine. any reason for this change?
There was a problem hiding this comment.
exposing hop_lengths from vqvae would make it simpler to do primed_sampling (making multiples, etc)
This was referenced May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.