fix: use APIStatusError.for instead of APIError.for in stream.rb #194
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-jpq
reviewed
Sep 4, 2025
| @@ -38,7 +38,7 @@ class Stream | |||
| else | |||
| "An error occurred during streaming" | |||
| end | |||
| err = OpenAI::Errors::APIError.for( | |||
| err = OpenAI::Errors::APIStatusError.for( | |||
There was a problem hiding this comment.
oh my god I am so sorry, this is such an embarrassing bug 🐛.
🤦♀️
ms-jpq
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Thank you so much for the PR @samuelreh! I will have this fix published in a jiffy.
I don't think I should merge this particular change though, unless we remote the claude code authorship for understandable reasons. 😅
|
@ms-jpq All good, feel free to regenerate it with GPT-5 💪 |
The APIError class doesn't have a 'for' class method, but APIStatusError does. This fixes a NoMethodError that would occur when streaming encounters an error. test: add test for streaming error handling with APIStatusError.for This test verifies that streaming error responses properly use APIStatusError.for instead of the non-existent APIError.for method.
samuelreh
force-pushed
the
fix-apierror-for-method
branch
from
93db98b to
666ad67
Compare
|
@ms-jpq I re-authored the commits and stripped the description of my buddy, feel free to merge if you think the fix is up to snuff. |
|
hey hey @samuelreh , thank you so much! |
Merged
stainless-app bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
The APIError class doesn't have a 'for' class method, but APIStatusError does. This fixes a NoMethodError that would occur when streaming encounters an error. test: add test for streaming error handling with APIStatusError.for This test verifies that streaming error responses properly use APIStatusError.for instead of the non-existent APIError.for method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI::Errors::APIError.forwas being called in stream.rb, but this method doesn't existOpenAI::Errors::APIStatusError.forwhich is the correct method that handles error creationProblem
The
APIErrorclass doesn't have aforclass method, butAPIStatusErrordoes. This was causing aNoMethodErrorwhen streaming encounters an error response.Solution
Updated lib/openai/internal/stream.rb line 41 to call
APIStatusError.forinstead ofAPIError.for.Test plan
APIStatusErrorclass has theformethod in lib/openai/errors.rb:149APIErrorclass does not have aformethod