Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell Rust you're not going to change the map #4

Closed
abdurraheemali opened this issue Dec 16, 2022 · 1 comment
Closed

Tell Rust you're not going to change the map #4

abdurraheemali opened this issue Dec 16, 2022 · 1 comment

Comments

@abdurraheemali
Copy link

tiktoken/src/lib.rs

Lines 419 to 421 in ab3688a

// Clone because I don't know how to tell Rust I'm not going to change the map
let mut sorted_token_bytes: Vec<Vec<u8>> = encoder.keys().cloned().collect();
sorted_token_bytes.sort();

@hauntsaninja
Copy link
Collaborator

Hello! Not sure why you've created an issue... I wrote that comment so I clearly already know about it ;-) If you want to change something, feel free to propose a PR. But in the meantime, I'm closing this, #5 and #6

@hauntsaninja hauntsaninja closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants