Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash two-tuples of ints instead of hashing bytes #6

Closed
abdurraheemali opened this issue Dec 16, 2022 · 1 comment
Closed

Hash two-tuples of ints instead of hashing bytes #6

abdurraheemali opened this issue Dec 16, 2022 · 1 comment

Comments

@abdurraheemali
Copy link

tiktoken/src/lib.rs

Lines 106 to 107 in ab3688a

// The current implementation ends up doing a lot of hashing of bytes. In theory, this could be made
// to be hashing of two-tuples of ints, which looks like it may also be a couple percent faster.

@hauntsaninja
Copy link
Collaborator

#4 (comment)

@hauntsaninja hauntsaninja closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants