Skip to content

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Aug 29, 2020

Do not merge. Some changes are still in progress, I'm just hoping to get code reviews started early since it's a pretty big change.

@dbanty dbanty requested a review from emann August 29, 2020 17:27
@dbanty dbanty self-assigned this Aug 29, 2020
Copy link
Collaborator

@emann emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

T = TypeVar("T")


@dataclass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is a dataclass instead of an attr.s?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just haven't converted anything except the client yet. I plan to convert both generated classes and those used internally before 0.6.0 is done.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #172 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         1276      1280    +4     
=========================================
+ Hits          1276      1280    +4     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)
openapi_python_client/cli.py 100.00% <100.00%> (ø)
openapi_python_client/parser/openapi.py 100.00% <100.00%> (ø)
openapi_python_client/parser/properties.py 100.00% <100.00%> (ø)
openapi_python_client/parser/reference.py 100.00% <100.00%> (ø)
openapi_python_client/parser/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fe79a...96172c2. Read the comment docs.

dbanty and others added 5 commits September 6, 2020 20:21
* Added auto_attribs=True to Client classes

* Update openapi_python_client/templates/client.pyi

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>

* Regenerated the golden record

* Regenerated golden record one more time

Co-authored-by: Ethan Mann <emann@triaxtec.com>
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
@dbanty dbanty requested a review from emann September 21, 2020 20:10
@dbanty
Copy link
Collaborator Author

dbanty commented Sep 21, 2020

This should be ready to go pending final approval.

Copy link
Collaborator

@emann emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this to finally be released!

@dbanty dbanty merged commit 150c6f7 into main Sep 21, 2020
@dbanty dbanty deleted the release/0.6.0 branch September 21, 2020 21:07
marshalc pushed a commit to ouhft/openapi-python-client that referenced this pull request Dec 23, 2024
marshalc pushed a commit to ouhft/openapi-python-client that referenced this pull request Dec 23, 2024
…ll allow the httpx library to ignore the ssl errors generated by the self-signed cert on the mirth appliances.

Also updated the Typer and httpx libraries to the latest versions.

Now we're back to having the problem with missing "description" fields in the original Mirth OAS file
marshalc pushed a commit to ouhft/openapi-python-client that referenced this pull request Dec 23, 2024
Squashed commit of the following:

commit b27bef9
Author: Carl Marshall <carl.marshall@ouh.nhs.uk>
Date:   Mon Dec 23 15:21:05 2024 +0000

    Fixes AB#172 - missed the AB ref off of the previous commit message.

commit a89de86
Author: Carl Marshall <carl.marshall@ouh.nhs.uk>
Date:   Mon Dec 23 15:18:52 2024 +0000

    Fixes openapi-generators#172 - Added an "insecure" cli option that will allow the httpx library to ignore the ssl errors generated by the self-signed cert on the mirth appliances.

    Also updated the Typer and httpx libraries to the latest versions.

    Now we're back to having the problem with missing "description" fields in the original Mirth OAS file

commit 84efd41
Author: Carl Marshall <carl.marshall@ouh.nhs.uk>
Date:   Mon Dec 23 14:42:00 2024 +0000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants