Skip to content

fix: Multipart uploads for httpx >= 0.19.0 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 17, 2022
Merged

fix: Multipart uploads for httpx >= 0.19.0 #548

merged 15 commits into from
Jan 17, 2022

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Dec 18, 2021 •
edited
Loading

Fixes #508

BREAKING CHANGE: File uploads can now only accept binary payloads (BinaryIO).

TODO:

  • Get integration tests working to start verifying end to end client functionality
  • Update Dobby to support separate breaking message from fix/feat message
  • Make an easy way to regenerate integration test client

@dbanty dbanty added the 🐞bug Something isn't working label Dec 18, 2021
@dbanty dbanty added this to the 0.11.0 milestone Dec 18, 2021
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from aa4f37a to 711ec49 Compare December 18, 2021 20:02
@dbanty dbanty mentioned this pull request Dec 18, 2021
Closed
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from 11ad683 to 3b6db1a Compare December 18, 2021 20:39
@codecov
Copy link

codecov bot commented Dec 18, 2021 •
edited
Loading

Codecov Report

Merging #548 (0ba5b91) into main (c9a4d03) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1661      1661           
=========================================
  Hits          1661      1661
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a4d03...0ba5b91. Read the comment docs.

@dbanty dbanty added the 🥚breaking This change breaks compatibility label Jan 1, 2022
dbanty added 3 commits January 15, 2022 17:38
@dbanty
fix: Multipart uploads for httpx >= 0.19.0
b4a9f85 
Fixes #508

BREAKING CHANGE: `File` uploads can now only accept binary payloads (`BinaryIO`).
@dbanty
ci: Add integration tests
1bd6feb
@dbanty
ci: Upgrade integration tests to use same Python version handling as …
e593056 
…normal checks
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from 1738c24 to e593056 Compare January 16, 2022 00:41
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from 1e2e5a5 to 35d331e Compare January 16, 2022 02:27
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch 2 times, most recently from c8a8691 to 85ab971 Compare January 17, 2022 03:38
dbanty
dbanty commented Jan 17, 2022
View reviewed changes
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from 43e3ed5 to c8ce749 Compare January 17, 2022 03:49
@dbanty dbanty force-pushed the 508-fix-file-uploads-on-httpx-0.19+ branch from c8ce749 to 0ba5b91 Compare January 17, 2022 03:50
@dbanty dbanty merged commit 3c86a70 into main Jan 17, 2022
@dbanty dbanty deleted the 508-fix-file-uploads-on-httpx-0.19+ branch January 17, 2022 04:05
dbanty added a commit that referenced this pull request Jan 17, 2022
@dbanty
fix: Multipart uploads for httpx >= 0.19.0 [#508, #548]. Thanks @skuo…
55cb94a 
…1-ilmn & @kairntech!

Fixes #508

BREAKING CHANGE: `File` uploads can now only accept binary payloads (`BinaryIO`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🥚breaking This change breaks compatibility 🐞bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

_get_kwargs does not produce correct payload when there are data and files present
1 participant
@dbanty