Support PDM #920
Merged
Support PDM #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
# Conflicts: # integration-tests/pdm.lock # pdm.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things drive this change—first, PEP621 has been around for a while now and Poetry shows no signs of adopting it, so while I don't want to ditch Poetry support (it's very popular), I do want a way to generate that style of metadata. PDM seems like a good target for that.
Second, Poetry has deprecated some plugins we use... or something. I didn't look into it, but we're getting warnings on every project build now. So, seems like time to switch over to something else. Conveniently, this will make the development commands shorter (
poetry run task checkbecomespdm check).TODO:
py.typedis included with a generated PDM project