Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java, improves schema generics #332

Merged
merged 111 commits into from
Dec 15, 2023
Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 12, 2023

Java, improves schema class generics

  • changes from 6 generics to 3 generics InType, CastType, OutType
  • makes one validator interface for each json type, 6 total
  • JsonSchema instances must implement getNewInstance that ingests Object and returns Object
    • this allows calls by getNewInstance after validation has been run to convert from cast data types to output data types

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether merged commit 6254a92 into master Dec 15, 2023
5 checks passed
@spacether spacether deleted the feat_java_changes_schema_generics branch December 15, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant