Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release docker image #2

Closed
2 tasks done
jessebot opened this issue May 21, 2024 · 4 comments · Fixed by #4
Closed
2 tasks done

Release docker image #2

jessebot opened this issue May 21, 2024 · 4 comments · Fixed by #4
Labels
enhancement New feature or request

Comments

@jessebot
Copy link

jessebot commented May 21, 2024

Description

We need to release this docker image to either quay.io, docker hub, or ghcr, so that we can use it in openbao-helm and wrap up openbao/openbao-helm#3

Looks like there's not actually a release workflow for this repo, so perhaps we can yoink the release workflow from the main repo and get it changed up for this repo:
https://github.com/openbao/openbao/blob/main/.github/workflows/release.yml

Dependencies

@jessebot
Copy link
Author

jessebot commented Jun 1, 2024

We have an openbao/openbao-k8s repo on quay.io that can be used for pushing up the docker image now :)

@jessebot
Copy link
Author

jessebot commented Jun 1, 2024

I am working on a PR for this now. Expect it in a day or two.

@ClaytonNorthey92
Copy link

hey @jessebot is there anything I can do to help with the pr? I was hoping to use the openbao-k8s Docker image on a project

jessebot added a commit to jessebot/openbao-k8s that referenced this issue Jun 24, 2024
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot
Copy link
Author

jessebot commented Jun 24, 2024

Sorry about that! I took some time off and hadn't touched this in a while. I think we need a PR for actually creating the docker release. I started a similar PR here: openbao/openbao-csi-provider#4 But I need feedback on that before I can mark #4 ready for review, as I'm not entirely sure what's involved, as I haven't pushed this docker image up before. (if you already know what to do, please feel free to comment on my open PR and I can make any edits, or submit a new PR and I can take a look through it :) )

jessebot added a commit to jessebot/openbao-k8s that referenced this issue Jul 6, 2024
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
jessebot added a commit to jessebot/openbao-k8s that referenced this issue Jul 6, 2024
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
jessebot added a commit to jessebot/openbao-k8s that referenced this issue Jul 6, 2024
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
@JanMa JanMa closed this as completed in #4 Jul 6, 2024
JanMa pushed a commit that referenced this issue Jul 6, 2024
* Create release.yml to fix #2

Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>

* add changes from openbao/openbao upstream repo

Signed-off-by: jessebot <jessebot@linux.com>

---------

Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants