Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing agreedToPolicy parameter when add adopter #857

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

dennis531
Copy link
Contributor

@dennis531 dennis531 commented Jul 30, 2024

No parameter agreedToPolicy is sent to Opencast, which means that the new policy will not be accepted in Opencast, but the old one will be. Thus, the data will not be sent to register.opencast.org. This pull request adds this missing parameter.

Related lines in Opencast:

@dennis531 dennis531 changed the title Fix missing agreed to policy parameter when add adopter Fix missing agreedToPolicy parameter when add adopter Jul 30, 2024
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-857

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-857

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/857/2024-07-30_15-39-25/ .
It might take a few minutes for it to become available.

@dennis531 dennis531 added the type:bug Something isn't working label Jul 30, 2024
@lkiesow lkiesow self-assigned this Jul 30, 2024
@lkiesow
Copy link
Member

lkiesow commented Jul 30, 2024

This seems to fix registration. Tried this and data end up on register.opencast.org

@lkiesow lkiesow merged commit 3584cdc into opencast:main Jul 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants