-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume control #1060
Add volume control #1060
Conversation
Hi @dennis531 |
This pull request is deployed at test.editor.opencast.org/1060/2023-05-22_12-21-47/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on.
It irks me that the Play Button is not centered anymore. Have you tried other layouts?
This might be one of the few cases where we can use an icon with no text, instead of only text. The audio control icon is pretty universal.
Dark mode stuff:
Not sure why the handle is transparent here. The blue highlighting glow is also barely visible. Also, this makes for a stylistic inconsistency, as no other element in the ui glows blue when hovered. Thoughts about making this more like the rest of the UI?
The audio level is persisted between different views which I like, but the slider does not reflect that. It will always reset to 100% upon switching views.
This pull request is deployed at test.editor.opencast.org/1060/2023-05-26_08-01-10/ . |
Icons are good. Maybe one would be enough? No hard opinion on that. Could make the left icon clickable for easy mute/unmute, but that's more of an extra and not required for this PR to go through. Persisting volume between views works. Visual feedback for hovering/focusing on the slider is now barely visible in light mode and completely illegible in dark mode. Still not fond of the arrangement of the controls. But I also have no idea how to keep the playbutton centered and order the other controls in an intuitive fashion. Would be nice if some design-inclined person could take a look at this. |
This pull request is deployed at test.editor.opencast.org/1060/2023-06-08_09-32-21/ . |
The volume icon can be used to mute the video. I hope the visual feedback for hovering on the slider is now more expressive. I hope that we will receive feedback about the arrangement of the controls. |
This pull request is deployed at test.editor.opencast.org/1060/2023-06-08_13-22-02/ . |
This pull request has conflicts ☹ |
This pull request is deployed at test.editor.opencast.org/1060/2023-07-04_08-41-28/ . |
This pull request has conflicts ☹ |
Hi @dennis531, could you rebase your PR? |
fe9c46d
to
4f28fb1
Compare
A rebase wasn't possible as some files were no longer present. Therefore, I re-implemented the changes based on the diff and adopted the appearance to the new design. |
This pull request is deployed at test.editor.opencast.org/1060/2023-09-27_12-22-31/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this for the redesign. Personally, I'm happy with how it looks and works. Will wait with merging a couple days so others can check it out too.
The two bars with the different controls are not aligned, which looks odd. This comes from trying to centre the play button. Which now is no longer centred and in trying to do so it would be unaligned the other way. I propose to just centre the two bars with the controls and not try to centre the play button. |
This pull request is deployed at test.editor.opencast.org/1060/2023-10-02_05-56-00/ . |
Looks good to me! |
Add a slider below the video to adjust the volume:
Closes #80