Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant Solr Search manager improvements #639

Closed
3 tasks done
imedina opened this issue Jul 3, 2017 · 0 comments
Closed
3 tasks done

Variant Solr Search manager improvements #639

imedina opened this issue Jul 3, 2017 · 0 comments
Assignees
@jtarraga @imedina
Labels
improvement search storage
Milestone
v1.2.0

Comments

@imedina
Copy link
Member

imedina commented Jul 3, 2017 •
edited
Loading

Current implementation needs some fixes and improvements:

  • New mode parameter to search configuration, we need to remove old 'collections' parameter since it is not needed
  • Move solr classes to 'solr' package, we currently only support Solr and current status is confusing
  • Ensure there is only one SolrClient (not HttpSolrClient) in VariantSearchManager and this is reused.
@imedina imedina added this to the v1.2.0 milestone Jul 3, 2017
imedina added a commit that referenced this issue Jul 3, 2017
@imedina
storage: improve Search configuration and remove unsed interface #639
fb3bbb4
imedina added a commit that referenced this issue Jul 3, 2017
@imedina
storage: some fixes in variant search tests #639
7483c3b
imedina added a commit that referenced this issue Jul 3, 2017
@imedina
storage: refactor search package to make clearer Solr dependent classes
7325bf6 
#639
@imedina imedina closed this as completed in cf17e0c Jul 3, 2017
j-coll added a commit that referenced this issue Jul 4, 2017
@j-coll
storage: Remove unused field "collection" from storage-configuration. #…
b6469d2 
…639
jtarraga added a commit that referenced this issue Jul 4, 2017
@jtarraga
storage: update storage configuration file, adding the parameter 'mod…
6620856 
…e' and removing the 'collection', #639
jtarraga added a commit that referenced this issue Jul 4, 2017
@jtarraga
storage: update isAlive function (VariantSearchManager) to take into …
ee61721 
…account the collection parameter, #639
jtarraga added a commit that referenced this issue Jul 5, 2017
@jtarraga
storage: call the function solrClient.commit with the parameter colle…
f5c686b 
…ction, #639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtarraga jtarraga

@imedina imedina

Labels
improvement search storage
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@jtarraga @imedina