Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK-2549 - Role and modeOfInheritance changes in Panel data model #2238

Merged
merged 5 commits into from
Feb 17, 2023
Merged

TASK-2549 - Role and modeOfInheritance changes in Panel data model #2238

merged 5 commits into from
Feb 17, 2023

Conversation

pfurio
Copy link
Member

@pfurio pfurio commented Jan 17, 2023

TASK-2549

@pfurio
Copy link
Member Author

pfurio commented Jan 17, 2023

Task linked: TASK-2549 Role and modeOfInheritance changes in Panel data model

@pfurio pfurio changed the title TASK-2549 TASK-2549 - Role and modeOfInheritance changes in Panel data model Jan 17, 2023
j-coll
j-coll requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@j-coll j-coll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about current usages of old/deprecated methods?
https://github.com/opencb/opencga/blob/develop/opencga-analysis/src/main/java/org/opencb/opencga/analysis/variant/manager/VariantCatalogQueryUtils.java#L915-L928

@pfurio pfurio merged commit e14d64b into develop Feb 17, 2023
@pfurio pfurio deleted the TASK-2549 branch February 17, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-coll j-coll j-coll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfurio @j-coll @juanfeSanahuja