Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove defunct untested code #400

Merged
merged 10 commits into from
Feb 20, 2017
Merged

Conversation

hredestig
Copy link
Contributor

fixes #383 #384

- gapfilling: broken implementation, poor fit to the package and plenty of better alternatives
- reporter metabolites: untested code destined for rewrite upon need
- optknock: moves to cameo
- gapfilling: broken implementation, poor fit to the package and plenty of better alternatives
- reporter metabolites: untested code destined for rewrite upon need
- optknock: moves to cameo
- convert to irreversible irrelevant with optlang
…ra/cobrapy into fix/remove-defunct-untested-code
@hredestig hredestig added ready WIP work in progress and removed ready labels Feb 17, 2017
@codecov-io
Copy link

Codecov Report

Merging #400 into devel-2 will increase coverage by 1.49%.
The diff coverage is 56.66%.

@@             Coverage Diff             @@
##           devel-2     #400      +/-   ##
===========================================
+ Coverage    64.05%   65.54%   +1.49%     
===========================================
  Files           67       65       -2     
  Lines         8098     7770     -328     
  Branches      1406     1351      -55     
===========================================
- Hits          5187     5093      -94     
+ Misses        2656     2434     -222     
+ Partials       255      243      -12
Impacted Files Coverage Δ
cobra/test/test_flux_analysis.py 87.44% <ø> (+2.34%)
cobra/util/init.py 100% <ø> (ø)
cobra/topology/reporter_metabolites.py 0% <ø> (ø)
cobra/test/test_manipulation.py 100% <100%> (+10.76%)
cobra/exceptions.py 63.63% <20%> (-36.37%)
cobra/design/design_algorithms.py 50% <50%> (+29.84%)
cobra/flux_analysis/gapfilling.py 50% <50%> (-4.95%)
cobra/core/solution.py 83.33% <ø> (-2.09%)
cobra/core/Reaction.py 83.98% <ø> (-0.44%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c701b...38711da. Read the comment docs.

Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :)

Copy link
Contributor

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks nice

@pstjohn
Copy link
Contributor

pstjohn commented Feb 17, 2017

Would you want to also include those __add__ methods we talked about removing? In model.py, for instance.

@hredestig
Copy link
Contributor Author

I'd prefer to see them moved out from the Model class I think but fits just as well in a different PR

@hredestig hredestig merged commit 9322a59 into devel-2 Feb 20, 2017
@hredestig hredestig deleted the fix/remove-defunct-untested-code branch February 20, 2017 08:01
@hredestig hredestig removed the WIP work in progress label Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants