-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove defunct untested code #400
Conversation
- gapfilling: broken implementation, poor fit to the package and plenty of better alternatives - reporter metabolites: untested code destined for rewrite upon need - optknock: moves to cameo
- gapfilling: broken implementation, poor fit to the package and plenty of better alternatives - reporter metabolites: untested code destined for rewrite upon need - optknock: moves to cameo - convert to irreversible irrelevant with optlang
…ra/cobrapy into fix/remove-defunct-untested-code
Codecov Report
@@ Coverage Diff @@
## devel-2 #400 +/- ##
===========================================
+ Coverage 64.05% 65.54% +1.49%
===========================================
Files 67 65 -2
Lines 8098 7770 -328
Branches 1406 1351 -55
===========================================
- Hits 5187 5093 -94
+ Misses 2656 2434 -222
+ Partials 255 243 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks nice
Would you want to also include those |
I'd prefer to see them moved out from the Model class I think but fits just as well in a different PR |
fixes #383 #384