-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metComps and utilities for Annotations #1396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extractCompartmentsFromMets could do with some usage examples
@ithiele this may affect Harvey computations. |
Codecov Report
@@ Coverage Diff @@
## integrationRAVEN #1396 +/- ##
===================================================
- Coverage 44.21% 43.72% -0.5%
===================================================
Files 904 901 -3
Lines 64715 64048 -667
===================================================
- Hits 28613 28004 -609
+ Misses 36102 36044 -58
Continue to review full report at Codecov.
|
@tpfau, is there any particular test that ensures backward compatibility? |
It passes all existing tests with only minimal modifications which are mainly due to the new fields being added and equality comparisons between existing models and manually manipulated models, as well as ensuring that the new fields are covered by the tests. |
c6abba1
to
c38f475
Compare
@tpfau, may you do a rebase here? Thanks 👍 |
c38f475
to
d24e0e2
Compare
@tpfau, may you do a rebase here? Thanks. |
This can actually be safely merged to |
This PR adds further utility functions for annotations and updates the existing functions (i.e. add/getMIRIAMAnnotation) to be more flexible with respect to outputs (potentially allowing this to be used during IO).
It also introduces the metComps field and adjusts several things required for this change.
I'm not sure, whether I caught all fields which rely on the metabolite names, but I actually haven't found many that do. And those that did were adjusted.
We will still need to "handle" compartment IDs in id names, if we want to find the "basic" metabolite for them (or rely on external ids for that purpose) but this PR should address at least some of it.
I hereby confirm that I have:
integrationRAVEN
as a target branch (top left drop-down menu)(Note: You may replace [ ] with [X] to check the box)