blake3: update to github.com/zeebo/blake3 v0.2.2 #94
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
|
Looks like I never pushed this one as well 😂 |
thaJeztah
commented
Sep 17, 2023
blake3/go.mod
Outdated
| require golang.org/x/sys v0.0.0-20201014080544-cc95f250f6bc // indirect | ||
| require github.com/klauspost/cpuid/v2 v2.0.12 // indirect |
There was a problem hiding this comment.
Honestly, this is the only concern, as we'd be adding more non-stdlib dependencies. Alternatively, I could set the minimum version to v0.2.2, which does not have this commit: zeebo/blake3@1e606d3
Do we know more context behind the choice to use the klauspost package for this one?
There was a problem hiding this comment.
v0.2.2 for now; consumers can still decide to pick a newer version, but perhaps someone knows more context about the choice between either of these
full diff: zeebo/blake3@v0.1.1...v0.2.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_blake3
branch
from
c2c246a
to
79188f3
Compare
thaJeztah
changed the title
AkihiroSuda
approved these changes
Sep 17, 2023
vbatts
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: zeebo/blake3@v0.1.1...v0.2.2