cgroupv2: use "max" for negative values #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cgroup v1 kernel doc [1] says: > We can write "-1" to reset the ``*.limit_in_bytes(unlimited)``. and cgroup v2 kernel documentation [2] says: > - If a controller implements an absolute resource guarantee and/or > limit, the interface files should be named "min" and "max" > respectively. If a controller implements best effort resource > guarantee and/or limit, the interface files should be named "low" > and "high" respectively. > > In the above four control files, the special token "max" should be > used to represent upward infinity for both reading and writing. Allow -1 value to still be used for v2, converting it to "max" where it makes sense to do so. This fixes the following issue: > runc update test_update --memory-swap -1: > error while setting cgroup v2: [write /sys/fs/cgroup/machine.slice/runc-cgroups-integration-test.scope/memory.swap.max: invalid argument > failed to write "-1" to "/sys/fs/cgroup/machine.slice/runc-cgroups-integration-test.scope/memory.swap.max" > github.com/opencontainers/runc/libcontainer/cgroups/fscommon.WriteFile > /home/kir/go/src/github.com/opencontainers/runc/libcontainer/cgroups/fscommon/fscommon.go:21 > github.com/opencontainers/runc/libcontainer/cgroups/fs2.setMemory > /home/kir/go/src/github.com/opencontainers/runc/libcontainer/cgroups/fs2/memory.go:20 > github.com/opencontainers/runc/libcontainer/cgroups/fs2.(*manager).Set > /home/kir/go/src/github.com/opencontainers/runc/libcontainer/cgroups/fs2/fs2.go:175 > github.com/opencontainers/runc/libcontainer/cgroups/systemd.(*UnifiedManager).Set > /home/kir/go/src/github.com/opencontainers/runc/libcontainer/cgroups/systemd/unified_hierarchy.go:290 > github.com/opencontainers/runc/libcontainer.(*linuxContainer).Set > /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:211 [1] linux/Documentation/admin-guide/cgroup-v1/memory.rst [2] linux/Documentation/admin-guide/cgroup-v2.rst Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
|
This patch is wrong: any negative value other than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgroup v1 kernel doc [1] says:
and cgroup v2 kernel documentation [2] says:
Allow -1 value to still be used for v2, converting it to "max"
where it makes sense to do so.
This fixes the following issue:
[1] linux/Documentation/admin-guide/cgroup-v1/memory.rst
[2] linux/Documentation/admin-guide/cgroup-v2.rst
@AkihiroSuda @mrunalp PTAL