Add the existing moby implementation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
imjasonh,
jcarter3,
mikebrow,
rchincha and
toddysm
as code owners
nathana1
reviewed
Sep 25, 2023
| ## API Workflow | ||
|
|
||
| - Ping the v2 endpoint (`GET /v2/`), if 401 (unauthorized status), save values from the `WWW-Authenticate` header | ||
| - Manually set scope to `repository:${repo}:${action}` with action = `pull`, `push`, or `pull,push` |
There was a problem hiding this comment.
It's worth double checking that last one. I know that it will make separate scopes instead of a single one with two actions if they are added separately. So the multiple action values may only be theoretical.
nathana1
reviewed
Sep 25, 2023
| - `refresh_token`: set if available | ||
| - `username`, `password`, `access_type=offline`: for password auth | ||
| - Request is set to the `realm` url | ||
| - Response is parsed for `access_token`, `refresh_token`, `expires_in`, `issued_at`, and `scope` |
There was a problem hiding this comment.
I don't believe JWT is explicitly supported. It's not parsing the content of the access token itself, so it may be JWT or any other opaque value.
AkihiroSuda
reviewed
Oct 30, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-implementation-moby
branch
from
91ba6bb
to
cd660dc
Compare
jcarter3
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a description of the existing moby/docker implementation supported by most registries today.