Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: CMAKE_ARGS already supported by scikit-build #830

Closed
4 tasks done
henryiii opened this issue Apr 11, 2023 · 0 comments · Fixed by #831
Closed
4 tasks done

config: CMAKE_ARGS already supported by scikit-build #830

henryiii opened this issue Apr 11, 2023 · 0 comments · Fixed by #831
Assignees

Comments

@henryiii
Copy link
Contributor

henryiii commented Apr 11, 2023

The setup.py in OpenCV-Python manually checks for CMAKE_ARGS, and places that in the cmake_args= setup keyword. Scikit-build itself does this, and also does some post-processing on CMAKE_ARGS that is missing here, including stripping CMAKE_INSTALL_PREFIX, which cannot be set by projects. The recent (a few hours ago) 0.17.0 release of scikit-build now produces an error if it detects CMAKE_INSTALL_PREFIX in cmake_args= (since it should not be passed in), but it ignores CMAKE_ARGS (since that get set lots of places like Conda).

The ideal fix would be to require scikit-build 0.14+, another fix would be to duplicate the filtering code in scikit-build: https://github.com/scikit-build/scikit-build/blob/6df6d571ba5c7be03729dd6b4d5e543c8aaae781/skbuild/setuptools_wrap.py#L545.

Seen in pyodide/pyodide#3753. That was easy to fix, but it's likely going to hit (at least) conda builds.

Issue submission checklist
  • This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)
  • I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)
  • The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")
  • I'm using the latest version of opencv-python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants