Update OpenCVDownload.cmake to fix log crash #11030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suppresses the interpretation of string literals by switching the ocv_download_log from a macro to a function. This avoid crashes when the string to log contains escape characters. More details about the problem this PR fixes are available at: opencv/opencv_contrib#1131
alalek
approved these changes
Mar 8, 2018
opencv-pushbot
pushed a commit
that referenced
this pull request
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
This PR changes the file
opencv-3.4.1/cmake/OpenCVDownload.cmake.It suppresses the interpretation of string literals by switching
ocv_download_logfrom a macro to a function.This avoid the interpretation of string literals, which is one of the root causes for build errors in opencv_contrib because the output of libcurl (used to download extra files) can contain characters like
\,which get interpreted and produce errors.More information about the difference between cmake macros and functions is available here:
More details about the problem this PR fixes are available at: