-
-
Notifications
You must be signed in to change notification settings - Fork 56.3k
Added/Fixed testcases for SIFT #17618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution!
Please take a look on notes below.
283bbdd
to
af0a231
Compare
Looks like the new test is too strict. Since the implementation at the moment use floating point values and therefore isn't bit-exact by nature there could be small differences depending on compiler optimization options and AVX2 availability. |
The relaxed test already exists. (https://github.com/opencv/opencv/blob/3.4/modules/features2d/test/test_descriptors_regression.cpp#L345) As we discussed in terfendail#3 (comment) and terfendail#3 (comment), I will withdraw 2d09bfb (with opencv/opencv_extra#768) and re-create a PR when a bit-exact version is implemented. |
af0a231
to
4e1895e
Compare
allows trainIdx duplication in matching scaled keypoints
4e1895e
to
dbfb2e4
Compare
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.