IPP: use linker workaround for Intel compiler on Linux #19838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Apr 2, 2021
| @@ -151,7 +151,7 @@ macro(ipp_detect_version) | |||
| if("${name}" STREQUAL "core") # https://github.com/opencv/opencv/pull/19681 | |||
| if(OPENCV_FORCE_IPP_EXCLUDE_LIBS OR OPENCV_FORCE_IPP_EXCLUDE_LIBS_CORE | |||
| OR (UNIX AND NOT ANDROID AND NOT APPLE | |||
| AND (CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| AND CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|Intel" | |||
There was a problem hiding this comment.
AFAIK, oneAPI compiler is identified as "Clang" compiler (at least for 2021.1).
CMAKE_CXX_COMPILER=/opt/intel/oneapi/compiler/2021.1.1/linux/bin/clang++
CMAKE_CXX_COMPILER=/opt/intel/oneapi/compiler/2021.1.1/linux/bin/clang++
CMAKE_CXX_COMPILER_ABI=ELF
CMAKE_CXX_COMPILER_AR=/opt/intel/oneapi/compiler/2021.1.1/linux/bin/llvm-ar
CMAKE_CXX_COMPILER_AR=/opt/intel/oneapi/compiler/2021.1.1/linux/bin/llvm-ar
CMAKE_CXX_COMPILER_ARCHITECTURE_ID=
CMAKE_CXX_COMPILER_ARG1=
CMAKE_CXX_COMPILER_ENV_VAR=CXX
CMAKE_CXX_COMPILER_FRONTEND_VARIANT=GNU
CMAKE_CXX_COMPILER_ID=Clang <<<====== here
Intel Compiler (from "Intel(R) Parallel Studio XE" product) is a different product.
There was a problem hiding this comment.
There are two compilers in oneAPI, I used icc which identifies as "Intel" (I think it is called classic in terms of oneAPI package):
-- C++ Compiler: /opt/intel/oneapi/compiler/2021.2.0/linux/bin/intel64/icc (ver 20.2.2.20210228)
alalek
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #19681 #10515
Tested on Ubuntu 18 with Intel Compiler (OneAPI 2021.2.0) and built-in IPPICV and standalone IPP (OneAPI 2021.2.0).