Skip to content

Move workflows to a dedicated repository for 5.x branch #22014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2022
Merged

Move workflows to a dedicated repository for 5.x branch #22014

merged 1 commit into from
May 22, 2022

Conversation

asenyaev
Copy link
Contributor

@asenyaev asenyaev commented May 19, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev asenyaev added the CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions) label May 19, 2022
@fengyuentau
Copy link
Member

How about putting all gha workflows in one single file for different branch. Different workflows can be distinguished by different job names. For example, instead of having PR-4.x-(ARM64|W10|U20).yaml, we can have one single file named PR-4.x.yaml with the following workflows:

jobs:
  ARM64-BuildAndTest:
    ...
  ARM64-BuildContrib:
    ...
  W10-BuildAndTest:
    ...
  ....

@asenyaev
Copy link
Contributor Author

asenyaev commented May 20, 2022

@fengyuentau it's a good point. In your idea we will reduce an amount of files in repositories, but will increase an amount of lines there. In addition, we will not be able to check the certain platform in Actions, I mean this part:

image

we will open the whole build and check what was wrong there, but on the PR page it will be shown almost without any changes. On the other hand, anything is located in one place.

I've tried to reproduce your idea, you can check it here:

@asmorkalov, what do you think about it?

@asenyaev asenyaev changed the title Draft: Move workflows to a dedicated repository for 5.x branch Move workflows to a dedicated repository for 5.x branch May 20, 2022
@asenyaev
Copy link
Contributor Author

@fengyuentau, I've updated a PR with a merged file for all platforms, but kept them split for the dedicated repository as we discussed on the meeting.

@alalek
Copy link
Member

alalek commented May 21, 2022

We need to check how we would use workflow "re-run" in this case. It would be nice to have ability to re-trigger job for single platform only (e.g. ARM only) in case of infrastructure failures/instability. Currently we have such ability.

@fengyuentau
Copy link
Member

If I am understanding correctly, there are two cases of re-running jobs after all jobs of a PR are done:

  • There is a 'Re-run all jobs' button on the top-left in the 'Checks' section. If it is clicked then all jobs will re-run regardless of success or fail.
  • Also in the 'Checks' section, if one wants to re-run lets say jobs for ARM64, then click 'PR: 4.x ARM64' and it leads to a summary page. On the top-left, there is a 'Re-run all jobs' button where you can select 'Re-run all jobs' or 'Re-run failed jobs' triggering only jobs for ARM64.

I did not find a button triggering only failed jobs for all platform though.

@alalek
Copy link
Member

alalek commented May 22, 2022

'Re-run failed jobs'

should work.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 6e9ab70 into opencv:5.x May 22, 2022
@asenyaev
Copy link
Contributor Author

'Re-run failed jobs'

should work.

Yes, it works. In addition, there are different use cases for re-run. Usually it works using "Re-run failed jobs", but you can re-run only one failed using a phone.

@alalek
Copy link
Member

alalek commented May 22, 2022

Actually it is possible to re-run any job from workflow (UI is hidden until you hover over the job's element).
So there is no problem at all.

gha-single-job

@asenyaev
Copy link
Contributor Author

Oh, great. It was a bit different some time ago, I thought they removed it from desktop UI.

@fengyuentau
Copy link
Member

Actually it is possible to re-run any job from workflow (UI is hidden until you hover over the job's element). So there is no problem at all.

gha-single-job

It seems we have to access from the 'Actions' -> 'All workflows' to get to the summary page of all platforms. I don't see a button in the 'Checks' section in a PR's page leading to the the summary page of all platforms, but only the summary page of a certain platform.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants