-
-
Notifications
You must be signed in to change notification settings - Fork 56.3k
Move workflows to a dedicated repository for 5.x branch #22014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How about putting all gha workflows in one single file for different branch. Different workflows can be distinguished by different job names. For example, instead of having jobs:
ARM64-BuildAndTest:
...
ARM64-BuildContrib:
...
W10-BuildAndTest:
...
.... |
@fengyuentau it's a good point. In your idea we will reduce an amount of files in repositories, but will increase an amount of lines there. In addition, we will not be able to check the certain platform in Actions, I mean this part: we will open the whole build and check what was wrong there, but on the PR page it will be shown almost without any changes. On the other hand, anything is located in one place. I've tried to reproduce your idea, you can check it here: @asmorkalov, what do you think about it? |
@fengyuentau, I've updated a PR with a merged file for all platforms, but kept them split for the dedicated repository as we discussed on the meeting. |
We need to check how we would use workflow "re-run" in this case. It would be nice to have ability to re-trigger job for single platform only (e.g. ARM only) in case of infrastructure failures/instability. Currently we have such ability. |
If I am understanding correctly, there are two cases of re-running jobs after all jobs of a PR are done:
I did not find a button triggering only failed jobs for all platform though. |
should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Yes, it works. In addition, there are different use cases for re-run. Usually it works using "Re-run failed jobs", but you can re-run only one failed using a phone. |
Oh, great. It was a bit different some time ago, I thought they removed it from desktop UI. |
It seems we have to access from the 'Actions' -> 'All workflows' to get to the summary page of all platforms. I don't see a button in the 'Checks' section in a PR's page leading to the the summary page of all platforms, but only the summary page of a certain platform. |
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.