Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link lib_acl_op_compiler when compile with CANN #24488

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

hipudding
Copy link
Contributor

@hipudding hipudding commented Nov 3, 2023

Ascend NPU is a series of AI processors.
hiascend.

This commit link lib_acl_op_compiler library when build with CANN backend. For implementation, please refer to opencv_contrib#3552

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • N/A There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fengyuentau
Copy link
Member

Looks like the doc warnings are from the PR in contrib, not this one:

# default
/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:433: warning: argument 'src' of command @param is not found in the argument list of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null())
/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:442: warning: The following parameters of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null()) are not documented:

# PR:4.x / docs
File size: 2963005 bytes = 2893 KiB = 2 MiB
Patch size default limit exceeded: 1024 KiB

@hipudding
Copy link
Contributor Author

hipudding commented Nov 3, 2023

Looks like the doc warnings are from the PR in contrib, not this one:


# default

/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:433: warning: argument 'src' of command @param is not found in the argument list of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null())

/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:442: warning: The following parameters of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null()) are not documented:



# PR:4.x / docs

File size: 2963005 bytes = 2893 KiB = 2 MiB

Patch size default limit exceeded: 1024 KiB

Thanks. These doc warnings already fixed in opencv_contrib repo.

@hipudding
Copy link
Contributor Author

hipudding commented Nov 6, 2023

The patch size is over 2MB because of the pictures in tutorials. The pictures has compressed.

@fengyuentau
Copy link
Member

Hello @hipudding , please make a dummy commit to re-trigger the build.

@hipudding
Copy link
Contributor Author

Hello @hipudding , please make a dummy commit to re-trigger the build.

Sure.

@hipudding
Copy link
Contributor Author

hipudding commented Nov 9, 2023

@asmorkalov This PR is approved and passed all the tests. Is it ready to merge? Thanks.

@asmorkalov asmorkalov merged commit b3791dc into opencv:4.x Nov 9, 2023
26 checks passed
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants