Skip to content

Fix typo #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2015
Merged

Fix typo #3967

merged 1 commit into from
Apr 28, 2015

Conversation

belev
Copy link
Contributor

@belev belev commented Apr 27, 2015

Fixed typos.

mshabunin
mshabunin reviewed Apr 28, 2015
View reviewed changes
doc/tutorials/core/basic_geometric_drawing/basic_geometric_drawing.markdown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to replace RGB with BGR here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so this should be changed in a lot of places I think because as I understand the RGB values are reversed in OpenCV as BGR. Maybe that way is better.

@mshabunin
Copy link
Contributor

@belev, thank you for contribution!
Can you, please, squash all commits into one?

@belev
Fix typo
2200e0f 
Fixed difference in the given arguments to the ellipse function and the description after that

Fixed two more typos

Replaced unnecessary the with to
@belev
Copy link
Contributor Author

belev commented Apr 28, 2015

I am glad that I can help with something. I think I squashed the commits into one, please tell me if it is OK now.

@mshabunin
Copy link
Contributor

It's OK.
👍

@opencv-pushbot opencv-pushbot merged commit 2200e0f into opencv:master Apr 28, 2015
vpisarev added a commit that referenced this pull request Apr 28, 2015
@vpisarev
Merge pull request #3967 from Belev:fix-typo
07e0765
@belev belev deleted the fix-typo branch April 28, 2015 14:53
@Dikay900 Dikay900 mentioned this pull request Apr 28, 2015
Merged
@mshabunin mshabunin removed their assignment Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belev @mshabunin @opencv-pushbot