fixing matlab wrapping #1119
Merged
fixing matlab wrapping #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Apr 12, 2017
|
|
||
| // --------------------------- Ptr_float ---------------------- | ||
| Bridge& operator=(const Ptr_float& ) { return *this; } | ||
| Ptr_float toPtrFloat() { return Ptr_float(); } |
There was a problem hiding this comment.
BTW, Looks like this method always create new empty "Ptr", so statement below will not use "input value" at all:
Ptr_float lowerBound = inputs[4].empty() ? (Ptr_float) Ptr<float>() : inputs[4].toPtrFloat();
There was a problem hiding this comment.
This is just to fix the build process. If they want to make sure the code is doing something useful, than that is for the guy of the other PR that wrapped this wrongfully xD
There was a problem hiding this comment.
But I get what you saying!
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves issue #1118